[material_ui] port drawer tests over from flutter/widgets by navaronbracke · Pull Request #12711 · flutter/packages

navaronbracke · 2026-09-01T08:57:01Z

This PR moves tests from packages/flutter under widgets/drawer_test.dart into material_ui.

Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear.
The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior.

Part of flutter/flutter#177028

See flutter/flutter#192106 which removes the tests in flutter/flutter

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

navaronbracke · 2026-09-01T08:58:43Z

    state.openDrawer();

    await tester.pump();
+    expect(find.text('Archive'), findsOneWidget);


This is ported over from the original test: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L32

navaronbracke · 2026-09-01T08:59:19Z


    expect(find.text('header'), findsOneWidget);
+
+    Navigator.pop(savedContext);


This is ported over from the original test https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L35-L39

gemini-code-assist

Code Review

This pull request ports drawer tests from flutter/widgets into material_ui, updating existing tests to verify drawer dismissal animations and adding several new tests covering tap, hover, gesture cancellation, and semantics behaviors. The review feedback suggests replacing hardcoded strings in the semantics tests (such as 'Dismiss' and 'Navigation menu') with localized values from DefaultMaterialLocalizations to make the tests robust against localization changes.

gemini-code-assist · 2026-09-01T08:59:43Z

+      await tester.pump(const Duration(milliseconds: 100));
+
+      expect(semantics, includesNodeWith(actions: <SemanticsAction>[SemanticsAction.tap]));
+      expect(semantics, includesNodeWith(label: 'Dismiss'));


Avoid using the hardcoded string 'Dismiss' for the semantics label. Instead, use const DefaultMaterialLocalizations().modalBarrierDismissLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(semantics, includesNodeWith(label: 'Dismiss'));

expect(semantics, includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel));

gemini-code-assist · 2026-09-01T08:59:43Z

+        includesNodeWith(actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus]),
+      ),
+    );
+    expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));


Avoid using the hardcoded string 'Dismiss' for the semantics label. Instead, use const DefaultMaterialLocalizations().modalBarrierDismissLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));

expect(semantics, isNot(includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel)));

gemini-code-assist · 2026-09-01T08:59:43Z

+    expect(
+      semantics,
+      includesNodeWith(
+        label: 'Navigation menu',
+        flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],
+      ),
+    );


Avoid using the hardcoded string 'Navigation menu' for the semantics label. Instead, use const DefaultMaterialLocalizations().drawerLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(

semantics,

includesNodeWith(

label: 'Navigation menu',

flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],

),

);

expect(

semantics,

includesNodeWith(

label: const DefaultMaterialLocalizations().drawerLabel,

flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],

),

);

navaronbracke · 2026-09-01T08:59:53Z

  testWidgets('Material3 - Drawer control test', (WidgetTester tester) async {
    const containerKey = Key('container');

+    late BuildContext savedContext;


The same changes as the test above were applied here, since we have the M2/M3 split

navaronbracke · 2026-09-01T09:00:11Z

    semantics.dispose();
  }, variant: TargetPlatformVariant.only(TargetPlatform.android));

+  testWidgets('Drawer tap test', (WidgetTester tester) async {


Moved over verbatim

navaronbracke · 2026-09-01T09:00:18Z

+    expect(find.text('drawer'), findsNothing);
+  });
+
+  testWidgets('Drawer hover test', (WidgetTester tester) async {


Moved over verbatim

navaronbracke · 2026-09-01T09:01:00Z

    expect(finder, findsNothing);
  });

+  testWidgets('Close drawer with navigator pop', (WidgetTester tester) async {


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L245

navaronbracke · 2026-09-01T09:02:20Z

+    expect(buttonPressed, equals(true));
+  });
+
+  testWidgets('Drawer closing can be canceled by gesture (LTR)', (WidgetTester tester) async {


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L146

navaronbracke · 2026-09-01T09:02:32Z

+    await gesture.up();
+  });
+
+  testWidgets('Drawer closing can be canceled by gesture (RTL)', (WidgetTester tester) async {


Same for this test

navaronbracke · 2026-09-01T09:03:16Z

  });

+  testWidgets(
+    'Dismissible Drawer includes button in semantic tree',


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L293

navaronbracke · 2026-09-01T09:03:47Z

+    }),
+  );
+
+  testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L324

navaronbracke · 2026-09-01T09:04:02Z

    await pumpDrawerWithTheme(TargetPlatform.iOS);
  }, variant: TargetPlatformVariant.all());

+  testWidgets('Drawer contains route semantics flags', (WidgetTester tester) async {


Moved over verbatim

port drawer tests over from flutter/widgets

bad25b4

flutter-dashboard Bot added the CICD Run CI/CD label Sep 1, 2026

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 1, 2026

navaronbracke commented Sep 1, 2026

View reviewed changes

gemini-code-assist Bot reviewed Sep 1, 2026

View reviewed changes

navaronbracke commented Sep 1, 2026

View reviewed changes

navaronbracke mentioned this pull request Sep 1, 2026

[cross_imports] Remove widgets/drawer_test.dart flutter/flutter#192106

Open

11 tasks

elliette requested review from QuncCccccc and elliette September 1, 2026 21:25


		expect(find.text('header'), findsOneWidget);

		Navigator.pop(savedContext);

	expect(semantics, includesNodeWith(label: 'Dismiss'));
	expect(semantics, includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel));

	expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));
	expect(semantics, isNot(includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel)));

Uh oh!

Conversation

navaronbracke commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

navaronbracke commented Sep 1, 2026 •

edited

Loading